This repository has been archived by the owner on Jul 1, 2022. It is now read-only.
[Backport to 0.34] Prevent a shutdown hook from being removed in JaegerTracer when a shutdown is in progress #690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## release-0.34 #690 +/- ##
==================================================
+ Coverage 89.39% 89.55% +0.15%
- Complexity 542 543 +1
==================================================
Files 68 68
Lines 1952 1953 +1
Branches 252 252
==================================================
+ Hits 1745 1749 +4
+ Misses 131 129 -2
+ Partials 76 75 -1
Continue to review full report at Codecov.
|
yurishkuro
reviewed
Feb 13, 2020
jaeger-core/src/main/java/io/jaegertracing/internal/JaegerTracer.java
Outdated
Show resolved
Hide resolved
TomasHofman
force-pushed
the
JBEAP-18312-followup
branch
from
742da46 to
a1adee8
Compare
…tdown is in progress Signed-off-by: Tomas Hofman <thofman@redhat.com>
TomasHofman
force-pushed
the
JBEAP-18312-followup
branch
from
a1adee8 to
fdd76f6
Compare
TomasHofman
changed the title
|
looks like a duplicate of #689 |
|
@yurishkuro this is for 0.34 stream. The original commit is in 0.34 too. |
yurishkuro
approved these changes
Feb 14, 2020
pavolloffay
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent a shutdown hook from being removed in JaegerTracer when a shutdown is in progress
Signed-off-by: Tomas Hofman thofman@redhat.com
Which problem is this PR solving?
This is follow up PR for #679
The problem this PR is solving that when a JaegerTracer is closed as a result of shutdown, the attempt to remove its' close shutdown hook fails with IllegalStateException. I.e. the shutdown hook cannot be removed when shutdown is already in progress.
Short description of the changes
Do not remove a shutdown hook when a shutdown is already in progress.